ida: use Domain API for interacting with the IDA Python SDK#2810
ida: use Domain API for interacting with the IDA Python SDK#2810williballenthin wants to merge 2 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
Summary of ChangesHello @williballenthin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the IDA Pro feature extraction component by transitioning its internal data access mechanisms to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the IDA feature extraction logic to use the new ida_domain API, replacing many direct idaapi and idc calls. This significantly modernizes the codebase and should improve maintainability and potentially robustness. The changes are consistently applied across the affected files, with the Database object being correctly passed as a parameter to relevant functions and stored as an instance variable in the IdaFeatureExtractor. The introduction of factory methods (from_current_database, from_file) in the extractor is a good design choice for managing the Database instance lifecycle.
|
|
||
|
|
||
| def check_segment_for_pe(seg: idaapi.segment_t) -> Iterator[tuple[int, int]]: | ||
| def check_segment_for_pe(db: Database, seg) -> Iterator[tuple[int, int]]: |
There was a problem hiding this comment.
The seg parameter in check_segment_for_pe is missing a type hint. It should likely be ida_domain.segments.Segment for clarity and type safety.
|
|
||
|
|
||
| def get_segment_buffer(seg: idaapi.segment_t) -> bytes: | ||
| def get_segment_buffer(db: Database, seg) -> bytes: |
There was a problem hiding this comment.
The seg parameter in get_segment_buffer is missing a type hint. It should likely be ida_domain.segments.Segment for clarity and type safety.
3 participants
Checklist